Feature: add stage 8 setuptools#65
Merged
jonathanrocher merged 7 commits intomasterfrom Jul 12, 2022
Merged
Conversation
Owner
Author
|
cc @siddhantwahal @prabhuramachandran @chamshop let me know if you agree this is useful. |
jonathanrocher
requested review from
chamshop,
prabhuramachandran and
siddhantwahal
siddhantwahal
requested changes
Jul 12, 2022
Collaborator
siddhantwahal
left a comment
siddhantwahal
left a comment
There was a problem hiding this comment.
This is still using the old models. Need more time to take a detailed look...
siddhantwahal
approved these changes
Jul 12, 2022
Owner
Author
|
Thanks for the review @siddhantwahal and catching the inconsistent models! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simply adds a fuller
setup.pyfile which collects all data files and adds a command line entry point. Simplify all other setup.py files so they are as simple as possible.